Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Remove main.less #10861

Merged
merged 1 commit into from
Sep 9, 2017
Merged

Remove main.less #10861

merged 1 commit into from
Sep 9, 2017

Conversation

luixxiul
Copy link
Contributor

@luixxiul luixxiul commented Sep 8, 2017 •
edited by bsclifton
Loading

Closes #10860

Auditors:

Test Plan:

  1. npm run watch
  2. npm start
  3. Make sure the browser starts

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.

Test Plan:

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

@luixxiul luixxiul self-assigned this Sep 8, 2017
bsclifton
bsclifton suggested changes Sep 9, 2017
View reviewed changes
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed these values are in use. If you open the Elements tab of the Muon dev tools (Shift + F8), you'll see that the body value of #000 is used and so is #f00 in #windowContainer.

Maybe it would be better to consolidate these- move into a different file.

@luixxiul
Copy link
Contributor Author

luixxiul commented Sep 9, 2017

Yes I confirmed that. Thanks for notifying it 👍

After that we should discuss if these values are actually necessary. I am not quite sure in which case those values are required. Maybe for debugging??

Move properties inside main.less to window.less
3eb4699 
Closes #10860

Auditors:

Test Plan:
1. npm run watch
2. npm start
3. Make sure the browser starts
4. Open the devtool and make sure the two properties are applied
@luixxiul luixxiul requested a review from bsclifton September 9, 2017 11:15
bsclifton
bsclifton approved these changes Sep 9, 2017
View reviewed changes
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@bsclifton bsclifton merged commit ca4cc2a into brave:master Sep 9, 2017
@luixxiul luixxiul deleted the remove-main-less branch September 9, 2017 17:39
This was referenced Sep 10, 2017
Closed
Merged
Merged
@luixxiul luixxiul added this to the 0.20.x (Beta Channel) milestone Oct 25, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bsclifton bsclifton bsclifton approved these changes

Assignees

@luixxiul luixxiul

Labels
QA/no-qa-needed release-notes/exclude
Projects
None yet
Milestone
0.20.x (Release Channel)
Development

Successfully merging this pull request may close these issues.
2 participants
@luixxiul @bsclifton